feat(cts): add new data source to query resource tags #7588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
force-pushed
the
feat_cts_resource_tag
branch
from
70d3e2f to
bcd8fad
Compare
Lance52259
reviewed
Aug 25, 2025
| @@ -745,7 +745,7 @@ func Provider() *schema.Provider { | |||
| "huaweicloud_cts_trackers": cts.DataSourceCtsTrackers(), | |||
| "huaweicloud_cts_operations": cts.DataSourceCtsOperations(), | |||
| "huaweicloud_cts_quotas": cts.DataSourceCtsQuotas(), | |||
| "huaweicloud_cts_resources": cts.DataSourceCtsResources(), | |||
There was a problem hiding this comment.
watch out, the right thing has been removed!
| httpUrl := "v3/{project_id}/{resource_type}/{resource_id}/tags" | ||
| path := client.Endpoint + httpUrl | ||
| path = strings.ReplaceAll(path, "{project_id}", client.ProjectID) | ||
| path = strings.ReplaceAll(path, "{resource_type}", "cts-tracker") |
There was a problem hiding this comment.
supports a filter parameter resource_type
Zippo-Wang
force-pushed
the
feat_cts_resource_tag
branch
5 times, most recently
from
638cfa8 to
b6ddac9
Compare
Zippo-Wang
force-pushed
the
feat_cts_resource_tag
branch
from
b6ddac9 to
dfe5e32
Compare
|
/approve |
github-ci-robot
added
LGTM
github-ci-robot
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
1.apply
2.plan
3.destroy
4.UT